fix(aci): update hits count for workflow fire history #103400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
saponifi3d
approved these changes
Nov 14, 2025
src/sentry/api/paginator.py
Outdated
| if known_hits is not None: | ||
| hits = known_hits | ||
| elif count_hits: | ||
| hits = self.count_hits(max_hits=MAX_HITS_LIMIT) |
Contributor
There was a problem hiding this comment.
it doesn't seem like we're using the max_hits variable from the method signature, should that be used here if set?
| ) | ||
|
|
||
| # Count distinct groups for pagination | ||
| group_count = qs.count() |
Contributor
There was a problem hiding this comment.
just a quick note that this will add another query and may impact performance; i'm guessing we need this to get the total number of results compared to the paginated list though.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| elif count_hits: | ||
| if max_hits is None: | ||
| max_hits = MAX_HITS_LIMIT | ||
| hits = self.count_hits(max_hits) |
Contributor
There was a problem hiding this comment.
Bug: Inconsistent Paginator Hit Counts
When known_hits is provided, it should be capped by max_hits for consistency with SequencePaginator. Currently, OffsetPaginator uses known_hits directly without applying the max_hits bound. If both parameters are provided together, hits could exceed max_hits, creating inconsistent behavior across paginators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug where
X-Hitswas turning the total sum of alerts (right column), rather than the total number of groups (rows in the table)